Payload
{
"action": "created",
"issue": {
"url": "https://api.github.com/repos/darkmatter/nixmac/issues/351",
"repository_url": "https://api.github.com/repos/darkmatter/nixmac",
"labels_url": "https://api.github.com/repos/darkmatter/nixmac/issues/351/labels{/name}",
"comments_url": "https://api.github.com/repos/darkmatter/nixmac/issues/351/comments",
"events_url": "https://api.github.com/repos/darkmatter/nixmac/issues/351/events",
"html_url": "https://github.com/darkmatter/nixmac/pull/351",
"id": 4618736129,
"node_id": "PR_kwDOSB6EzM7kNLVB",
"number": 351,
"title": "ENG-502: Add direct OpenAI provider support",
"user": {
"login": "fkb032",
"id": 249513614,
"node_id": "U_kgDODt9Gjg",
"avatar_url": "https://avatars.githubusercontent.com/u/249513614?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fkb032",
"html_url": "https://github.com/fkb032",
"followers_url": "https://api.github.com/users/fkb032/followers",
"following_url": "https://api.github.com/users/fkb032/following{/other_user}",
"gists_url": "https://api.github.com/users/fkb032/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fkb032/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fkb032/subscriptions",
"organizations_url": "https://api.github.com/users/fkb032/orgs",
"repos_url": "https://api.github.com/users/fkb032/repos",
"events_url": "https://api.github.com/users/fkb032/events{/privacy}",
"received_events_url": "https://api.github.com/users/fkb032/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "open",
"locked": false,
"assignees": [],
"milestone": null,
"comments": 4,
"created_at": "2026-06-09T04:11:56Z",
"updated_at": "2026-06-10T14:41:44Z",
"closed_at": null,
"assignee": null,
"author_association": "CONTRIBUTOR",
"issue_field_values": [],
"type": null,
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/darkmatter/nixmac/pulls/351",
"html_url": "https://github.com/darkmatter/nixmac/pull/351",
"diff_url": "https://github.com/darkmatter/nixmac/pull/351.diff",
"patch_url": "https://github.com/darkmatter/nixmac/pull/351.patch",
"merged_at": null
},
"body": "## Summary\n\n- Adds OpenAI as a first-class direct provider alongside OpenRouter, with separate provider selection, API-key storage, base URL handling, and model choices.\n- Routes evolve and summary generation through explicit OpenAI vs OpenRouter backend paths instead of treating OpenRouter as the only OpenAI-compatible provider.\n- Adds legacy preference migration plus validation/test coverage so existing OpenRouter-backed settings are not silently interpreted as direct OpenAI.\n- Updates Settings -> API Keys so direct OpenAI keys use the same verify-before-save flow and verified/saved status UI as OpenRouter.\n- Handles review feedback by preserving compatible migrated OpenRouter model slugs, defaulting bare OpenAI model names during legacy migration, and omitting custom temperature for OpenAI reasoning models.\n\n## Review Notes\n\n- Planned OpenAI key verification, ran `$claude-review`, implemented, then ran a second `$claude-review` on the code diff.\n- Accepted Claude's implementation feedback for stale async verification results and the duplicated `ApiKeyStatus` type.\n- Ran `nixmac-code-review`, froze the patch proposals, then ran those proposals through `$claude-review` before applying changes.\n- Applied the legitimate review feedback: slug-safe model migration and real Rust temperature handling for reasoning models. Rejected the full API-key save queue as over-engineering after review.\n- No blocking Claude/nixmac-code-review issues remain.\n\n## Test Plan\n\n- [x] `bunx vitest run --project=unit src/ipc/api.test.ts src/lib/ai-provider-validation.test.ts src/lib/ai-provider-migration.test.ts`\n- [x] `bunx vitest run --project=unit src/lib/api-key-verification.test.ts src/ipc/api.test.ts src/lib/ai-provider-validation.test.ts src/lib/ai-provider-migration.test.ts`\n- [x] `bun run build` from `apps/native`\n- [x] `cargo test --manifest-path apps/native/src-tauri/Cargo.toml model_capabilities`\n- [x] `cargo test --manifest-path apps/native/src-tauri/Cargo.toml direct_openai_`\n- [x] `cargo test --manifest-path apps/native/src-tauri/Cargo.toml`\n- [x] `git diff --check`\n- [x] Live running-app smoke test with direct OpenAI `gpt-4o` generating successfully through the evolve flow\n- [x] Live running-app Settings smoke test: API Keys tab shows OpenAI password input, OpenAI copy/link, and `API key verified and saved.` when a saved OpenAI key exists\n\nKnown unrelated repo-wide checks:\n\n- `cargo fmt --check` fails on existing formatting/trailing-whitespace issues outside this branch.\n- `npx ultracite check` / `bunx ultracite check` fails before file checking because the current `biome.json` contains unsupported rule keys for the installed Biome/Ultracite version.\n\n## Docs\n\n- [ ] Docs updated (companion PR in darkmatter/nixmac-web: #___)\n- [x] No docs update needed\n",
"reactions": {
"url": "https://api.github.com/repos/darkmatter/nixmac/issues/351/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/darkmatter/nixmac/issues/351/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comment": {
"url": "https://api.github.com/repos/darkmatter/nixmac/issues/comments/4671425720",
"html_url": "https://github.com/darkmatter/nixmac/pull/351#issuecomment-4671425720",
"issue_url": "https://api.github.com/repos/darkmatter/nixmac/issues/351",
"id": 4671425720,
"node_id": "IC_kwDOSB6EzM8AAAABFnBMuA",
"user": {
"login": "czxtm",
"id": 1325802,
"node_id": "MDQ6VXNlcjEzMjU4MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/1325802?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/czxtm",
"html_url": "https://github.com/czxtm",
"followers_url": "https://api.github.com/users/czxtm/followers",
"following_url": "https://api.github.com/users/czxtm/following{/other_user}",
"gists_url": "https://api.github.com/users/czxtm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/czxtm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/czxtm/subscriptions",
"organizations_url": "https://api.github.com/users/czxtm/orgs",
"repos_url": "https://api.github.com/users/czxtm/repos",
"events_url": "https://api.github.com/users/czxtm/events{/privacy}",
"received_events_url": "https://api.github.com/users/czxtm/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-06-10T14:41:44Z",
"updated_at": "2026-06-10T14:41:44Z",
"body": "closing, this must've gotten rebased since it includes unrelated code, needs to be re written against develop",
"author_association": "MEMBER",
"reactions": {
"url": "https://api.github.com/repos/darkmatter/nixmac/issues/comments/4671425720/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
"repository": {
"id": 1209959628,
"node_id": "R_kgDOSB6EzA",
"name": "nixmac",
"full_name": "darkmatter/nixmac",
"private": false,
"owner": {
"login": "darkmatter",
"id": 17834193,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjE3ODM0MTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/17834193?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/darkmatter",
"html_url": "https://github.com/darkmatter",
"followers_url": "https://api.github.com/users/darkmatter/followers",
"following_url": "https://api.github.com/users/darkmatter/following{/other_user}",
"gists_url": "https://api.github.com/users/darkmatter/gists{/gist_id}",
"starred_url": "https://api.github.com/users/darkmatter/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/darkmatter/subscriptions",
"organizations_url": "https://api.github.com/users/darkmatter/orgs",
"repos_url": "https://api.github.com/users/darkmatter/repos",
"events_url": "https://api.github.com/users/darkmatter/events{/privacy}",
"received_events_url": "https://api.github.com/users/darkmatter/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"html_url": "https://github.com/darkmatter/nixmac",
"description": "Home manager and nix-darwin that understands plain English",
"fork": false,
"url": "https://api.github.com/repos/darkmatter/nixmac",
"forks_url": "https://api.github.com/repos/darkmatter/nixmac/forks",
"keys_url": "https://api.github.com/repos/darkmatter/nixmac/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/darkmatter/nixmac/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/darkmatter/nixmac/teams",
"hooks_url": "https://api.github.com/repos/darkmatter/nixmac/hooks",
"issue_events_url": "https://api.github.com/repos/darkmatter/nixmac/issues/events{/number}",
"events_url": "https://api.github.com/repos/darkmatter/nixmac/events",
"assignees_url": "https://api.github.com/repos/darkmatter/nixmac/assignees{/user}",
"branches_url": "https://api.github.com/repos/darkmatter/nixmac/branches{/branch}",
"tags_url": "https://api.github.com/repos/darkmatter/nixmac/tags",
"blobs_url": "https://api.github.com/repos/darkmatter/nixmac/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/darkmatter/nixmac/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/darkmatter/nixmac/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/darkmatter/nixmac/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/darkmatter/nixmac/statuses/{sha}",
"languages_url": "https://api.github.com/repos/darkmatter/nixmac/languages",
"stargazers_url": "https://api.github.com/repos/darkmatter/nixmac/stargazers",
"contributors_url": "https://api.github.com/repos/darkmatter/nixmac/contributors",
"subscribers_url": "https://api.github.com/repos/darkmatter/nixmac/subscribers",
"subscription_url": "https://api.github.com/repos/darkmatter/nixmac/subscription",
"commits_url": "https://api.github.com/repos/darkmatter/nixmac/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/darkmatter/nixmac/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/darkmatter/nixmac/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/darkmatter/nixmac/issues/comments{/number}",
"contents_url": "https://api.github.com/repos/darkmatter/nixmac/contents/{+path}",
"compare_url": "https://api.github.com/repos/darkmatter/nixmac/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/darkmatter/nixmac/merges",
"archive_url": "https://api.github.com/repos/darkmatter/nixmac/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/darkmatter/nixmac/downloads",
"issues_url": "https://api.github.com/repos/darkmatter/nixmac/issues{/number}",
"pulls_url": "https://api.github.com/repos/darkmatter/nixmac/pulls{/number}",
"milestones_url": "https://api.github.com/repos/darkmatter/nixmac/milestones{/number}",
"notifications_url": "https://api.github.com/repos/darkmatter/nixmac/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/darkmatter/nixmac/labels{/name}",
"releases_url": "https://api.github.com/repos/darkmatter/nixmac/releases{/id}",
"deployments_url": "https://api.github.com/repos/darkmatter/nixmac/deployments",
"created_at": "2026-04-14T00:37:13Z",
"updated_at": "2026-06-10T14:11:15Z",
"pushed_at": "2026-06-10T14:08:33Z",
"git_url": "git://github.com/darkmatter/nixmac.git",
"ssh_url": "git@github.com:darkmatter/nixmac.git",
"clone_url": "https://github.com/darkmatter/nixmac.git",
"svn_url": "https://github.com/darkmatter/nixmac",
"homepage": "https://nixmac.com",
"size": 681524,
"stargazers_count": 5,
"watchers_count": 5,
"language": "Rust",
"has_issues": true,
"has_projects": false,
"has_downloads": true,
"has_wiki": false,
"has_pages": false,
"has_discussions": false,
"forks_count": 1,
"mirror_url": null,
"archived": false,
"disabled": false,
"open_issues_count": 86,
"license": {
"key": "mit",
"name": "MIT License",
"spdx_id": "MIT",
"url": "https://api.github.com/licenses/mit",
"node_id": "MDc6TGljZW5zZTEz"
},
"allow_forking": true,
"is_template": false,
"web_commit_signoff_required": false,
"has_pull_requests": true,
"pull_request_creation_policy": "all",
"topics": [
"home-manager",
"nix",
"nix-darwin",
"nix-flake",
"opencode"
],
"visibility": "public",
"forks": 1,
"open_issues": 86,
"watchers": 5,
"default_branch": "develop",
"custom_properties": {}
},
"organization": {
"login": "darkmatter",
"id": 17834193,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjE3ODM0MTkz",
"url": "https://api.github.com/orgs/darkmatter",
"repos_url": "https://api.github.com/orgs/darkmatter/repos",
"events_url": "https://api.github.com/orgs/darkmatter/events",
"hooks_url": "https://api.github.com/orgs/darkmatter/hooks",
"issues_url": "https://api.github.com/orgs/darkmatter/issues",
"members_url": "https://api.github.com/orgs/darkmatter/members{/member}",
"public_members_url": "https://api.github.com/orgs/darkmatter/public_members{/member}",
"avatar_url": "https://avatars.githubusercontent.com/u/17834193?v=4",
"description": ""
},
"enterprise": {
"id": 469843,
"slug": "darkmatter",
"name": "darkmatter",
"node_id": "E_kgDOAAcrUw",
"avatar_url": "https://avatars.githubusercontent.com/b/469843?v=4",
"description": "",
"website_url": "darkmatter.io",
"html_url": "https://github.com/enterprises/darkmatter",
"created_at": "2025-09-07T16:01:00Z",
"updated_at": "2026-06-07T16:53:26Z"
},
"sender": {
"login": "czxtm",
"id": 1325802,
"node_id": "MDQ6VXNlcjEzMjU4MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/1325802?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/czxtm",
"html_url": "https://github.com/czxtm",
"followers_url": "https://api.github.com/users/czxtm/followers",
"following_url": "https://api.github.com/users/czxtm/following{/other_user}",
"gists_url": "https://api.github.com/users/czxtm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/czxtm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/czxtm/subscriptions",
"organizations_url": "https://api.github.com/users/czxtm/orgs",
"repos_url": "https://api.github.com/users/czxtm/repos",
"events_url": "https://api.github.com/users/czxtm/events{/privacy}",
"received_events_url": "https://api.github.com/users/czxtm/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"installation": {
"id": 131074261,
"node_id": "MDIzOkludGVncmF0aW9uSW5zdGFsbGF0aW9uMTMxMDc0MjYx"
}
}