Payload
{
"action": "created",
"issue": {
"url": "https://api.github.com/repos/voytravel/travel-frens/issues/280",
"repository_url": "https://api.github.com/repos/voytravel/travel-frens",
"labels_url": "https://api.github.com/repos/voytravel/travel-frens/issues/280/labels{/name}",
"comments_url": "https://api.github.com/repos/voytravel/travel-frens/issues/280/comments",
"events_url": "https://api.github.com/repos/voytravel/travel-frens/issues/280/events",
"html_url": "https://github.com/voytravel/travel-frens/pull/280",
"id": 4927634045,
"node_id": "PR_kwDOSa9ZX87zxxW7",
"number": 280,
"title": "fix(swipe): stop closing map view after swiping a map-opened card ENG-1215",
"user": {
"login": "CasLinden",
"id": 83954807,
"node_id": "MDQ6VXNlcjgzOTU0ODA3",
"avatar_url": "https://avatars.githubusercontent.com/u/83954807?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/CasLinden",
"html_url": "https://github.com/CasLinden",
"followers_url": "https://api.github.com/users/CasLinden/followers",
"following_url": "https://api.github.com/users/CasLinden/following{/other_user}",
"gists_url": "https://api.github.com/users/CasLinden/gists{/gist_id}",
"starred_url": "https://api.github.com/users/CasLinden/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/CasLinden/subscriptions",
"organizations_url": "https://api.github.com/users/CasLinden/orgs",
"repos_url": "https://api.github.com/users/CasLinden/repos",
"events_url": "https://api.github.com/users/CasLinden/events{/privacy}",
"received_events_url": "https://api.github.com/users/CasLinden/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": false,
"assignees": [],
"milestone": null,
"comments": 2,
"created_at": "2026-07-20T09:31:36Z",
"updated_at": "2026-07-20T10:04:02Z",
"closed_at": "2026-07-20T09:45:52Z",
"assignee": null,
"author_association": "COLLABORATOR",
"issue_field_values": [],
"type": null,
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/voytravel/travel-frens/pulls/280",
"html_url": "https://github.com/voytravel/travel-frens/pull/280",
"diff_url": "https://github.com/voytravel/travel-frens/pull/280.diff",
"patch_url": "https://github.com/voytravel/travel-frens/pull/280.patch",
"merged_at": "2026-07-20T09:45:52Z"
},
"body": null,
"reactions": {
"url": "https://api.github.com/repos/voytravel/travel-frens/issues/280/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/voytravel/travel-frens/issues/280/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comment": {
"url": "https://api.github.com/repos/voytravel/travel-frens/issues/comments/5021029531",
"html_url": "https://github.com/voytravel/travel-frens/pull/280#issuecomment-5021029531",
"issue_url": "https://api.github.com/repos/voytravel/travel-frens/issues/280",
"id": 5021029531,
"node_id": "IC_kwDOSa9ZX88AAAABK0bUmw",
"user": {
"login": "darkmatter[bot]",
"id": 283346107,
"node_id": "BOT_kgDOEOOEuw",
"avatar_url": "https://avatars.githubusercontent.com/in/3663660?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/darkmatter%5Bbot%5D",
"html_url": "https://github.com/apps/darkmatter",
"followers_url": "https://api.github.com/users/darkmatter%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/darkmatter%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/darkmatter%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/darkmatter%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/darkmatter%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/darkmatter%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/darkmatter%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/darkmatter%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/darkmatter%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-07-20T10:04:02Z",
"updated_at": "2026-07-20T10:04:02Z",
"body": "Confirmed: I cannot post the review to GitHub (bot token lacks access to the private repo), and the task statement said the sandbox has no repo access. I'll deliver the full review here for you to post.\n\n---\n\n## Analysis\n\nThe change removes one line — `setMapOpen(false)` from `swipeFromMap` — so that swiping a pin-opened card leaves the map open instead of snapping back to the deck. The updated comment reflects the new intent (\"closing only the pin card\").\n\n**Correctness — this is sound for the stated goal.** With `setPinPlace(null)` still called, the pin card closes; keeping `mapOpen` true leaves the map as the top overlay. No other call sites of `swipeFromMap` are shown in the diff, so there's no conflicting path visible. The diff is minimal and the behavioral delta matches the PR title (ENG-1215).\n\n**One real concern worth flagging as an inline comment:** the deleted `setMapOpen(false)` was the only thing returning the user to the deck after a map-sourced swipe. Without a replacement exit, the user is now left on the map after every swipe-from-map decision. The PR frames this as intended, but the reviewer should confirm there's a *separate* affordance to dismiss the map (Esc handler, a close button, back gesture) — otherwise the map becomes a dead-end with no documented exit. From the surrounding comment, an Escape handler exists (\"Escape closes the topmost overlay\"), so the exit path likely remains; still worth the author confirming.\n\nNo security issues — the change is purely local React state management with no I/O, networking, or trust-boundary impact.\n\nBelow is the review formatted for posting. The `path:line` anchors use the post-diff line numbers from the provided unified diff (the `setPinPlace(null)` / removed `setMapOpen(false)` block sits around the `@@ -422,7 +422,6 @@` hunk).\n\n---\n\n### Summary comment\n\n> **Overall: Looks good — minimal and correct for the stated goal.**\n>\n> Removing `setMapOpen(false)` from `swipeFromMap` leaves the map open after a map-sourced swipe, with `setPinPlace(null)` still closing the pin card. The updated comment accurately reflects the new behavior. No correctness or security concerns in the diff itself.\n>\n> One thing to confirm before merge: with `setMapOpen(false)` gone, is there still a clear path to dismiss the map after a swipe (Escape handler / close button / back gesture)? The surrounding comment suggests Escape closes the topmost overlay, so the exit likely remains — just want to make sure the map doesn't become a dead-end state with no way back to the deck.\n\n### Inline comment — `src/pages/TripSwipe.tsx`, the `setPinPlace(null)` line (post-diff, ~line 423)\n\n> With `setMapOpen(false)` removed, the user is left on the map after every swipe-from-map decision. Confirm an explicit map-dismiss affordance still exists (Escape / close button) so the map never becomes a dead-end. If it does, this is fine as-is; if not, consider wiring one.\n\n---\n\n**Posting blocker:** my sandbox bot token (`darkmatter[bot]`) has no access to `voytravel/travel-frens` — the repo 404s on every `gh`/REST call (it's private and not granted to the bot). I can't post the review programmatically; please paste the summary + inline comment above into the PR, or grant the bot read access to the repo and I'll post it directly.",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/voytravel/travel-frens/issues/comments/5021029531/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 3663660,
"client_id": "Iv23lifA2SLzhklKJM5M",
"slug": "darkmatter",
"node_id": "A_kwHOARAg0c4AN-cs",
"owner": {
"login": "darkmatter",
"id": 17834193,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjE3ODM0MTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/17834193?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/darkmatter",
"html_url": "https://github.com/darkmatter",
"followers_url": "https://api.github.com/users/darkmatter/followers",
"following_url": "https://api.github.com/users/darkmatter/following{/other_user}",
"gists_url": "https://api.github.com/users/darkmatter/gists{/gist_id}",
"starred_url": "https://api.github.com/users/darkmatter/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/darkmatter/subscriptions",
"organizations_url": "https://api.github.com/users/darkmatter/orgs",
"repos_url": "https://api.github.com/users/darkmatter/repos",
"events_url": "https://api.github.com/users/darkmatter/events{/privacy}",
"received_events_url": "https://api.github.com/users/darkmatter/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "darkmatter",
"description": "This is the darkmatter agent - mention the bot to have it review PR's, fix issues, and drive the agent.",
"external_url": "https://dm.sh",
"html_url": "https://github.com/apps/darkmatter",
"created_at": "2026-05-10T08:36:27Z",
"updated_at": "2026-07-01T11:26:40Z",
"permissions": {
"actions": "write",
"actions_variables": "read",
"agent_secrets": "read",
"agent_variables": "read",
"checks": "write",
"contents": "write",
"copilot_agent_settings": "write",
"custom_properties_for_organizations": "write",
"deployments": "write",
"discussions": "write",
"enterprise_organization_installations": "write",
"enterprise_organization_installation_repositories": "write",
"environments": "write",
"issues": "write",
"issue_fields": "read",
"issue_types": "read",
"members": "read",
"metadata": "read",
"organization_actions_variables": "write",
"organization_administration": "write",
"organization_agent_secrets": "read",
"organization_agent_variables": "read",
"organization_codespaces": "write",
"organization_codespaces_secrets": "write",
"organization_copilot_agent_settings": "read",
"organization_custom_properties": "write",
"organization_dependabot_dismissal_requests": "read",
"organization_dependabot_secrets": "read",
"organization_events": "read",
"organization_hooks": "write",
"organization_personal_access_tokens": "write",
"organization_personal_access_token_requests": "write",
"organization_private_registries": "write",
"organization_secrets": "write",
"organization_self_hosted_runners": "write",
"org_copilot_content_exclusion": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"secrets": "read",
"statuses": "write",
"user_events": "read",
"workflows": "write"
},
"events": [
"commit_comment",
"create",
"deployment",
"deployment_review",
"deployment_status",
"discussion",
"discussion_comment",
"issues",
"issue_comment",
"merge_queue_entry",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"pull_request_review_thread",
"release",
"status",
"sub_issues",
"workflow_dispatch",
"workflow_job",
"workflow_run"
]
},
"minimized": null
},
"repository": {
"id": 1236228447,
"node_id": "R_kgDOSa9ZXw",
"name": "travel-frens",
"full_name": "voytravel/travel-frens",
"private": true,
"owner": {
"login": "voytravel",
"id": 213144510,
"node_id": "O_kgDODLRTvg",
"avatar_url": "https://avatars.githubusercontent.com/u/213144510?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/voytravel",
"html_url": "https://github.com/voytravel",
"followers_url": "https://api.github.com/users/voytravel/followers",
"following_url": "https://api.github.com/users/voytravel/following{/other_user}",
"gists_url": "https://api.github.com/users/voytravel/gists{/gist_id}",
"starred_url": "https://api.github.com/users/voytravel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/voytravel/subscriptions",
"organizations_url": "https://api.github.com/users/voytravel/orgs",
"repos_url": "https://api.github.com/users/voytravel/repos",
"events_url": "https://api.github.com/users/voytravel/events{/privacy}",
"received_events_url": "https://api.github.com/users/voytravel/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"html_url": "https://github.com/voytravel/travel-frens",
"description": null,
"fork": false,
"url": "https://api.github.com/repos/voytravel/travel-frens",
"forks_url": "https://api.github.com/repos/voytravel/travel-frens/forks",
"keys_url": "https://api.github.com/repos/voytravel/travel-frens/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/voytravel/travel-frens/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/voytravel/travel-frens/teams",
"hooks_url": "https://api.github.com/repos/voytravel/travel-frens/hooks",
"issue_events_url": "https://api.github.com/repos/voytravel/travel-frens/issues/events{/number}",
"events_url": "https://api.github.com/repos/voytravel/travel-frens/events",
"assignees_url": "https://api.github.com/repos/voytravel/travel-frens/assignees{/user}",
"branches_url": "https://api.github.com/repos/voytravel/travel-frens/branches{/branch}",
"tags_url": "https://api.github.com/repos/voytravel/travel-frens/tags",
"blobs_url": "https://api.github.com/repos/voytravel/travel-frens/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/voytravel/travel-frens/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/voytravel/travel-frens/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/voytravel/travel-frens/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/voytravel/travel-frens/statuses/{sha}",
"languages_url": "https://api.github.com/repos/voytravel/travel-frens/languages",
"stargazers_url": "https://api.github.com/repos/voytravel/travel-frens/stargazers",
"contributors_url": "https://api.github.com/repos/voytravel/travel-frens/contributors",
"subscribers_url": "https://api.github.com/repos/voytravel/travel-frens/subscribers",
"subscription_url": "https://api.github.com/repos/voytravel/travel-frens/subscription",
"commits_url": "https://api.github.com/repos/voytravel/travel-frens/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/voytravel/travel-frens/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/voytravel/travel-frens/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/voytravel/travel-frens/issues/comments{/number}",
"contents_url": "https://api.github.com/repos/voytravel/travel-frens/contents/{+path}",
"compare_url": "https://api.github.com/repos/voytravel/travel-frens/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/voytravel/travel-frens/merges",
"archive_url": "https://api.github.com/repos/voytravel/travel-frens/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/voytravel/travel-frens/downloads",
"issues_url": "https://api.github.com/repos/voytravel/travel-frens/issues{/number}",
"pulls_url": "https://api.github.com/repos/voytravel/travel-frens/pulls{/number}",
"milestones_url": "https://api.github.com/repos/voytravel/travel-frens/milestones{/number}",
"notifications_url": "https://api.github.com/repos/voytravel/travel-frens/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/voytravel/travel-frens/labels{/name}",
"releases_url": "https://api.github.com/repos/voytravel/travel-frens/releases{/id}",
"deployments_url": "https://api.github.com/repos/voytravel/travel-frens/deployments",
"created_at": "2026-05-12T04:06:46Z",
"updated_at": "2026-07-20T09:46:46Z",
"pushed_at": "2026-07-20T09:57:32Z",
"git_url": "git://github.com/voytravel/travel-frens.git",
"ssh_url": "org-213144510@github.com:voytravel/travel-frens.git",
"clone_url": "https://github.com/voytravel/travel-frens.git",
"svn_url": "https://github.com/voytravel/travel-frens",
"homepage": null,
"size": 10500,
"stargazers_count": 0,
"watchers_count": 0,
"language": "TypeScript",
"has_issues": true,
"has_projects": true,
"has_downloads": true,
"has_wiki": false,
"has_pages": false,
"has_discussions": false,
"forks_count": 0,
"mirror_url": null,
"archived": false,
"disabled": false,
"open_issues_count": 5,
"license": null,
"allow_forking": false,
"is_template": false,
"web_commit_signoff_required": false,
"has_pull_requests": true,
"pull_request_creation_policy": "all",
"topics": [],
"visibility": "private",
"forks": 0,
"open_issues": 5,
"watchers": 0,
"default_branch": "develop",
"custom_properties": {}
},
"organization": {
"login": "voytravel",
"id": 213144510,
"node_id": "O_kgDODLRTvg",
"url": "https://api.github.com/orgs/voytravel",
"repos_url": "https://api.github.com/orgs/voytravel/repos",
"events_url": "https://api.github.com/orgs/voytravel/events",
"hooks_url": "https://api.github.com/orgs/voytravel/hooks",
"issues_url": "https://api.github.com/orgs/voytravel/issues",
"members_url": "https://api.github.com/orgs/voytravel/members{/member}",
"public_members_url": "https://api.github.com/orgs/voytravel/public_members{/member}",
"avatar_url": "https://avatars.githubusercontent.com/u/213144510?v=4",
"description": ""
},
"enterprise": {
"id": 469843,
"slug": "darkmatter",
"name": "darkmatter",
"node_id": "E_kgDOAAcrUw",
"avatar_url": "https://avatars.githubusercontent.com/b/469843?v=4",
"description": "",
"website_url": "darkmatter.io",
"html_url": "https://github.com/enterprises/darkmatter",
"created_at": "2025-09-07T16:01:00Z",
"updated_at": "2026-07-07T15:59:26Z"
},
"sender": {
"login": "darkmatter[bot]",
"id": 283346107,
"node_id": "BOT_kgDOEOOEuw",
"avatar_url": "https://avatars.githubusercontent.com/in/3663660?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/darkmatter%5Bbot%5D",
"html_url": "https://github.com/apps/darkmatter",
"followers_url": "https://api.github.com/users/darkmatter%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/darkmatter%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/darkmatter%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/darkmatter%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/darkmatter%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/darkmatter%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/darkmatter%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/darkmatter%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/darkmatter%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"installation": {
"id": 143976268,
"node_id": "MDIzOkludGVncmF0aW9uSW5zdGFsbGF0aW9uMTQzOTc2MjY4"
}
}