Payload
{
"action": "created",
"issue": {
"url": "https://api.github.com/repos/darkmatter/nixmac/issues/563",
"repository_url": "https://api.github.com/repos/darkmatter/nixmac",
"labels_url": "https://api.github.com/repos/darkmatter/nixmac/issues/563/labels{/name}",
"comments_url": "https://api.github.com/repos/darkmatter/nixmac/issues/563/comments",
"events_url": "https://api.github.com/repos/darkmatter/nixmac/issues/563/events",
"html_url": "https://github.com/darkmatter/nixmac/pull/563",
"id": 4925034858,
"node_id": "PR_kwDOSB6EzM7zpTjr",
"number": 563,
"title": "feature: show git auto-update status (read-only) in the UI when env var is set",
"user": {
"login": "scottmcmaster",
"id": 3137688,
"node_id": "MDQ6VXNlcjMxMzc2ODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/3137688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/scottmcmaster",
"html_url": "https://github.com/scottmcmaster",
"followers_url": "https://api.github.com/users/scottmcmaster/followers",
"following_url": "https://api.github.com/users/scottmcmaster/following{/other_user}",
"gists_url": "https://api.github.com/users/scottmcmaster/gists{/gist_id}",
"starred_url": "https://api.github.com/users/scottmcmaster/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/scottmcmaster/subscriptions",
"organizations_url": "https://api.github.com/users/scottmcmaster/orgs",
"repos_url": "https://api.github.com/users/scottmcmaster/repos",
"events_url": "https://api.github.com/users/scottmcmaster/events{/privacy}",
"received_events_url": "https://api.github.com/users/scottmcmaster/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "open",
"locked": false,
"assignees": [],
"milestone": null,
"comments": 2,
"created_at": "2026-07-20T01:05:22Z",
"updated_at": "2026-07-20T01:34:49Z",
"closed_at": null,
"assignee": null,
"author_association": "COLLABORATOR",
"issue_field_values": [],
"type": null,
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/darkmatter/nixmac/pulls/563",
"html_url": "https://github.com/darkmatter/nixmac/pull/563",
"diff_url": "https://github.com/darkmatter/nixmac/pull/563.diff",
"patch_url": "https://github.com/darkmatter/nixmac/pull/563.patch",
"merged_at": null
},
"body": "## Summary\r\n\r\nA previous PR of mine put in place a change to check in the background and log if we detected that we were in a state where we could do a git fast-forward pull on behalf of the user and log the result. This change extends that work to hook the result up to the UI based on an environment variable which will eventually be a UI preference, namely `NIXMAC_GIT_AUTO_UPDATE_MODE`.\r\n\r\nYou will see this behavior if you set `NIXMAC_GIT_AUTO_UPDATE_MODE` to `confirm` or `auto`; otherwise we won't even check.\r\n\r\n<img width=\"787\" height=\"601\" alt=\"Screenshot 2026-07-20 at 8 46 22 AM\" src=\"https://github.com/user-attachments/assets/d8f3377b-85a2-4d24-9a26-be7834e8bd28\" />\r\n\r\n## Test Plan\r\n\r\nMostly manual with some small unit testing around the env var / pref.\r\n\r\n- [ ] No test plan needed\r\n\r\n## Docs\r\n\r\n- [ ] Docs updated (companion PR in darkmatter/nixmac-web: #\\_\\_\\_)\r\n- [x] No docs update needed\r\n",
"reactions": {
"url": "https://api.github.com/repos/darkmatter/nixmac/issues/563/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/darkmatter/nixmac/issues/563/timeline",
"performed_via_github_app": {
"id": 158384,
"client_id": "Iv1.922be7c1ac51d2aa",
"slug": "graphite-app",
"node_id": "A_kwHOA7ErVM4AAmqw",
"owner": {
"login": "withgraphite",
"id": 61942612,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjYxOTQyNjEy",
"avatar_url": "https://avatars.githubusercontent.com/u/61942612?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/withgraphite",
"html_url": "https://github.com/withgraphite",
"followers_url": "https://api.github.com/users/withgraphite/followers",
"following_url": "https://api.github.com/users/withgraphite/following{/other_user}",
"gists_url": "https://api.github.com/users/withgraphite/gists{/gist_id}",
"starred_url": "https://api.github.com/users/withgraphite/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/withgraphite/subscriptions",
"organizations_url": "https://api.github.com/users/withgraphite/orgs",
"repos_url": "https://api.github.com/users/withgraphite/repos",
"events_url": "https://api.github.com/users/withgraphite/events{/privacy}",
"received_events_url": "https://api.github.com/users/withgraphite/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "Graphite App",
"description": "Graphite is a code review platform on top of GitHub that makes creating & code reviewing stacked diffs intuitive, fast, and delightful.",
"external_url": "https://graphite.dev",
"html_url": "https://github.com/apps/graphite-app",
"created_at": "2021-12-13T17:14:28Z",
"updated_at": "2026-02-02T18:37:14Z",
"permissions": {
"actions": "write",
"administration": "read",
"checks": "write",
"contents": "write",
"deployments": "read",
"emails": "read",
"issues": "write",
"members": "read",
"metadata": "read",
"organization_custom_properties": "read",
"organization_custom_roles": "read",
"pull_requests": "write",
"statuses": "read",
"workflows": "write"
},
"events": [
"branch_protection_configuration",
"branch_protection_rule",
"check_run",
"check_suite",
"deployment",
"deployment_status",
"issue_comment",
"label",
"member",
"membership",
"merge_queue_entry",
"organization",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"pull_request_review_thread",
"push",
"repository",
"repository_ruleset",
"status",
"team",
"team_add",
"workflow_job",
"workflow_run"
]
},
"state_reason": null
},
"comment": {
"url": "https://api.github.com/repos/darkmatter/nixmac/issues/comments/5018052155",
"html_url": "https://github.com/darkmatter/nixmac/pull/563#issuecomment-5018052155",
"issue_url": "https://api.github.com/repos/darkmatter/nixmac/issues/563",
"id": 5018052155,
"node_id": "IC_kwDOSB6EzM8AAAABKxlmOw",
"user": {
"login": "darkmatter[bot]",
"id": 283346107,
"node_id": "BOT_kgDOEOOEuw",
"avatar_url": "https://avatars.githubusercontent.com/in/3663660?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/darkmatter%5Bbot%5D",
"html_url": "https://github.com/apps/darkmatter",
"followers_url": "https://api.github.com/users/darkmatter%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/darkmatter%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/darkmatter%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/darkmatter%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/darkmatter%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/darkmatter%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/darkmatter%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/darkmatter%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/darkmatter%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-07-20T01:34:49Z",
"updated_at": "2026-07-20T01:34:49Z",
"body": "Confirmed: the inline-comments verification endpoint is returning HTTP 503 (the GitHub backend serving that route is degraded), not a creation failure. The review POST succeeded authoritatively.\n\n---\n\n**Review posted:** [#563 review 4731772926](https://github.com/darkmatter/nixmac/pull/563#pullrequestreview-4731772926) — `COMMENTED` event (non-blocking), 2350-char summary + 6 inline comments.\n\nNote on the briefing: the platform told me the diff was unavailable (installation lookup 503) and the sandbox had no repo access. Neither was true in practice — `gh` was authenticated as `darkmatter[bot]` and the full 5268-line diff + head blobs were retrievable. I reviewed the actual code, not just the description.\n\n## Findings (summary)\n\n1. **Env-var value mismatch (user-visible bug)** — `watcher.rs:55`. PR body says set `NIXMAC_GIT_AUTO_UPDATE_MODE` to `confirm` or `auto`; the parser accepts `\"automatic\"`, not `\"auto\"`. Following the docs (`auto`) hits the catch-all, logs a warning, and silently disables the feature. *(inline)*\n2. **Read-modify-write race on the `GitState` cell** — `watcher.rs:232–237`. Spawned auto-update thread does `get` (clone) → mutate → `update` (non-atomic compare-then-write), racing the main loop's `git_state::update` every ~100ms. Can clobber fresher `git_status`/`external_build_detected` or lose the flag write. Low blast radius today (one-tick-stale banner), real TOCTOU once the update flow stops being read-only. *(inline ×2)*\n3. **Sticky banner, no dismiss/clear path** — `upstream-update-available.tsx:16`. Text says \"Update it before making more changes\" implying an action, but there's no button/link and no dismiss; flag only re-evaluates every 5 min, so it persists across ticks even after an external pull. Suggest wording matching the read-only intent. *(inline)*\n4. **Banner only on `begin` step** — `begin-step.tsx:44`. Disappears once the user advances to `evolve`/`commit`/`manualEvolve`/`manualCommit`. Flagged for a conscious decision, not a defect. *(inline)*\n5. **`from_env()` runs every 100ms tick** — `watcher.rs:221`. `std::env::var` re-read ~10×/sec while watching. Minor; cache it. *(inline)*\n\n**Good:** The wiring end-to-end (Rust `GitState` → observable → frontend store → banner) is consistent; the early-return path in `get_git_state` correctly preserves the flag (`git.rs:183`); all mock/test sites updated to the new struct shape; `check_auto_update` remains read-only (`fast_forward_to_upstream` is still TODO/unused), so no destructive git mutation is introduced.\n\nNo commits pushed, no code changed — review-only as instructed.",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/darkmatter/nixmac/issues/comments/5018052155/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 3663660,
"client_id": "Iv23lifA2SLzhklKJM5M",
"slug": "darkmatter",
"node_id": "A_kwHOARAg0c4AN-cs",
"owner": {
"login": "darkmatter",
"id": 17834193,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjE3ODM0MTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/17834193?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/darkmatter",
"html_url": "https://github.com/darkmatter",
"followers_url": "https://api.github.com/users/darkmatter/followers",
"following_url": "https://api.github.com/users/darkmatter/following{/other_user}",
"gists_url": "https://api.github.com/users/darkmatter/gists{/gist_id}",
"starred_url": "https://api.github.com/users/darkmatter/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/darkmatter/subscriptions",
"organizations_url": "https://api.github.com/users/darkmatter/orgs",
"repos_url": "https://api.github.com/users/darkmatter/repos",
"events_url": "https://api.github.com/users/darkmatter/events{/privacy}",
"received_events_url": "https://api.github.com/users/darkmatter/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "darkmatter",
"description": "This is the darkmatter agent - mention the bot to have it review PR's, fix issues, and drive the agent.",
"external_url": "https://dm.sh",
"html_url": "https://github.com/apps/darkmatter",
"created_at": "2026-05-10T08:36:27Z",
"updated_at": "2026-07-01T11:26:40Z",
"permissions": {
"actions": "write",
"actions_variables": "read",
"agent_secrets": "read",
"agent_variables": "read",
"checks": "write",
"contents": "write",
"copilot_agent_settings": "write",
"custom_properties_for_organizations": "write",
"deployments": "write",
"discussions": "write",
"enterprise_organization_installations": "write",
"enterprise_organization_installation_repositories": "write",
"environments": "write",
"issues": "write",
"issue_fields": "read",
"issue_types": "read",
"members": "read",
"metadata": "read",
"organization_actions_variables": "write",
"organization_administration": "write",
"organization_agent_secrets": "read",
"organization_agent_variables": "read",
"organization_codespaces": "write",
"organization_codespaces_secrets": "write",
"organization_copilot_agent_settings": "read",
"organization_custom_properties": "write",
"organization_dependabot_dismissal_requests": "read",
"organization_dependabot_secrets": "read",
"organization_events": "read",
"organization_hooks": "write",
"organization_personal_access_tokens": "write",
"organization_personal_access_token_requests": "write",
"organization_private_registries": "write",
"organization_secrets": "write",
"organization_self_hosted_runners": "write",
"org_copilot_content_exclusion": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"secrets": "read",
"statuses": "write",
"user_events": "read",
"workflows": "write"
},
"events": [
"commit_comment",
"create",
"deployment",
"deployment_review",
"deployment_status",
"discussion",
"discussion_comment",
"issues",
"issue_comment",
"merge_queue_entry",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"pull_request_review_thread",
"release",
"status",
"sub_issues",
"workflow_dispatch",
"workflow_job",
"workflow_run"
]
},
"minimized": null
},
"repository": {
"id": 1209959628,
"node_id": "R_kgDOSB6EzA",
"name": "nixmac",
"full_name": "darkmatter/nixmac",
"private": false,
"owner": {
"login": "darkmatter",
"id": 17834193,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjE3ODM0MTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/17834193?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/darkmatter",
"html_url": "https://github.com/darkmatter",
"followers_url": "https://api.github.com/users/darkmatter/followers",
"following_url": "https://api.github.com/users/darkmatter/following{/other_user}",
"gists_url": "https://api.github.com/users/darkmatter/gists{/gist_id}",
"starred_url": "https://api.github.com/users/darkmatter/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/darkmatter/subscriptions",
"organizations_url": "https://api.github.com/users/darkmatter/orgs",
"repos_url": "https://api.github.com/users/darkmatter/repos",
"events_url": "https://api.github.com/users/darkmatter/events{/privacy}",
"received_events_url": "https://api.github.com/users/darkmatter/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"html_url": "https://github.com/darkmatter/nixmac",
"description": "Home manager and nix-darwin that understands plain English",
"fork": false,
"url": "https://api.github.com/repos/darkmatter/nixmac",
"forks_url": "https://api.github.com/repos/darkmatter/nixmac/forks",
"keys_url": "https://api.github.com/repos/darkmatter/nixmac/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/darkmatter/nixmac/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/darkmatter/nixmac/teams",
"hooks_url": "https://api.github.com/repos/darkmatter/nixmac/hooks",
"issue_events_url": "https://api.github.com/repos/darkmatter/nixmac/issues/events{/number}",
"events_url": "https://api.github.com/repos/darkmatter/nixmac/events",
"assignees_url": "https://api.github.com/repos/darkmatter/nixmac/assignees{/user}",
"branches_url": "https://api.github.com/repos/darkmatter/nixmac/branches{/branch}",
"tags_url": "https://api.github.com/repos/darkmatter/nixmac/tags",
"blobs_url": "https://api.github.com/repos/darkmatter/nixmac/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/darkmatter/nixmac/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/darkmatter/nixmac/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/darkmatter/nixmac/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/darkmatter/nixmac/statuses/{sha}",
"languages_url": "https://api.github.com/repos/darkmatter/nixmac/languages",
"stargazers_url": "https://api.github.com/repos/darkmatter/nixmac/stargazers",
"contributors_url": "https://api.github.com/repos/darkmatter/nixmac/contributors",
"subscribers_url": "https://api.github.com/repos/darkmatter/nixmac/subscribers",
"subscription_url": "https://api.github.com/repos/darkmatter/nixmac/subscription",
"commits_url": "https://api.github.com/repos/darkmatter/nixmac/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/darkmatter/nixmac/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/darkmatter/nixmac/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/darkmatter/nixmac/issues/comments{/number}",
"contents_url": "https://api.github.com/repos/darkmatter/nixmac/contents/{+path}",
"compare_url": "https://api.github.com/repos/darkmatter/nixmac/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/darkmatter/nixmac/merges",
"archive_url": "https://api.github.com/repos/darkmatter/nixmac/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/darkmatter/nixmac/downloads",
"issues_url": "https://api.github.com/repos/darkmatter/nixmac/issues{/number}",
"pulls_url": "https://api.github.com/repos/darkmatter/nixmac/pulls{/number}",
"milestones_url": "https://api.github.com/repos/darkmatter/nixmac/milestones{/number}",
"notifications_url": "https://api.github.com/repos/darkmatter/nixmac/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/darkmatter/nixmac/labels{/name}",
"releases_url": "https://api.github.com/repos/darkmatter/nixmac/releases{/id}",
"deployments_url": "https://api.github.com/repos/darkmatter/nixmac/deployments",
"created_at": "2026-04-14T00:37:13Z",
"updated_at": "2026-07-19T23:12:23Z",
"pushed_at": "2026-07-20T01:07:16Z",
"git_url": "git://github.com/darkmatter/nixmac.git",
"ssh_url": "org-17834193@github.com:darkmatter/nixmac.git",
"clone_url": "https://github.com/darkmatter/nixmac.git",
"svn_url": "https://github.com/darkmatter/nixmac",
"homepage": "https://nixmac.com",
"size": 688805,
"stargazers_count": 21,
"watchers_count": 21,
"language": "Rust",
"has_issues": true,
"has_projects": false,
"has_downloads": true,
"has_wiki": false,
"has_pages": true,
"has_discussions": true,
"forks_count": 2,
"mirror_url": null,
"archived": false,
"disabled": false,
"open_issues_count": 99,
"license": {
"key": "mit",
"name": "MIT License",
"spdx_id": "MIT",
"url": "https://api.github.com/licenses/mit",
"node_id": "MDc6TGljZW5zZTEz"
},
"allow_forking": true,
"is_template": false,
"web_commit_signoff_required": false,
"has_pull_requests": true,
"pull_request_creation_policy": "all",
"topics": [
"home-manager",
"nix",
"nix-darwin",
"nix-flake",
"opencode"
],
"visibility": "public",
"forks": 2,
"open_issues": 99,
"watchers": 21,
"default_branch": "main",
"custom_properties": {}
},
"organization": {
"login": "darkmatter",
"id": 17834193,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjE3ODM0MTkz",
"url": "https://api.github.com/orgs/darkmatter",
"repos_url": "https://api.github.com/orgs/darkmatter/repos",
"events_url": "https://api.github.com/orgs/darkmatter/events",
"hooks_url": "https://api.github.com/orgs/darkmatter/hooks",
"issues_url": "https://api.github.com/orgs/darkmatter/issues",
"members_url": "https://api.github.com/orgs/darkmatter/members{/member}",
"public_members_url": "https://api.github.com/orgs/darkmatter/public_members{/member}",
"avatar_url": "https://avatars.githubusercontent.com/u/17834193?v=4",
"description": ""
},
"enterprise": {
"id": 469843,
"slug": "darkmatter",
"name": "darkmatter",
"node_id": "E_kgDOAAcrUw",
"avatar_url": "https://avatars.githubusercontent.com/b/469843?v=4",
"description": "",
"website_url": "darkmatter.io",
"html_url": "https://github.com/enterprises/darkmatter",
"created_at": "2025-09-07T16:01:00Z",
"updated_at": "2026-07-07T15:59:26Z"
},
"sender": {
"login": "darkmatter[bot]",
"id": 283346107,
"node_id": "BOT_kgDOEOOEuw",
"avatar_url": "https://avatars.githubusercontent.com/in/3663660?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/darkmatter%5Bbot%5D",
"html_url": "https://github.com/apps/darkmatter",
"followers_url": "https://api.github.com/users/darkmatter%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/darkmatter%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/darkmatter%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/darkmatter%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/darkmatter%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/darkmatter%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/darkmatter%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/darkmatter%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/darkmatter%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"installation": {
"id": 131074261,
"node_id": "MDIzOkludGVncmF0aW9uSW5zdGFsbGF0aW9uMTMxMDc0MjYx"
}
}